[flashrom-gerrit] Change in flashrom[master]: buspirate_spi.c: Refactor singleton states into reentrant pattern

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52958 )

Change subject: buspirate_spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 4:

(1 comment)

File buspirate_spi.c:

https://review.coreboot.org/c/flashrom/+/52958/comment/8d1dadac_9d98d939 
PS4, Line 315: int buspirate_spi_init(void)
Perhaps a bit out of scope for this commit however you may wish to add one or two change before this?

I would be keen to see this function split up some as it is exceedingly large. I suspect many nice properties will fall out of the process of doing that.

By splitting init cleanup paths and intermediates will likely become a lot simpler to follow.