Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File buspirate_spi.c:

  • Patch Set #4, Line 315: int buspirate_spi_init(void)

    Perhaps a bit out of scope for this commit however you may wish to add one or two change before this?

    I would be keen to see this function split up some as it is exceedingly large. I suspect many nice properties will fall out of the process of doing that.

    By splitting init cleanup paths and intermediates will likely become a lot simpler to follow.

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.