Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36717 )
Change subject: flashchips: Add W25Q128JW_DTR
......................................................................
Patch Set 3:
(1 comment)
Nico, any objections to getting this in? Looks harmless enough to me
No objections. A candidate for the fastest flashrom merge ever? ^^
https://review.coreboot.org/c/flashrom/+/36717/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/36717/3//COMMIT_MSG@11
PS3, Line 11: BUG=b:144297264
Not a fan of private references. In the coreboot project, this has
often led to confusion and fruitless discussions.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/36717
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifc28878b17dc10da2cfd8f82fffbd57adb22799e
Gerrit-Change-Number: 36717
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Nov 2019 12:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment