Attention is currently required from: Aarya, Bill XIE.
Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email )
Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: Sorry for some delay, I am getting back to this. I want to add a test into this patch, because now it's possible to add such test (after CB:84783).
If it goes by the plan, I will upload new patchset with test, hope it's fine.
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84721/comment/130b3202_9beea412?usp... : PS3, Line 124: " --sacrifice-ratio <ratio> The percentage of overall sub-blocks needless to\n" : " change within a larger erase block to be sacrificed\n" : " for programming speed, default 0, max 100\n" I was thinking, maybe to change this description a bit, to make it more clear: but I haven't composed anything in my head yet :) just keep thinking on the background. If I don't come up with anything, then that will be it.
In any case, definitely will keep the DANGEROUS! warning.
https://review.coreboot.org/c/flashrom/+/84721/comment/ad5825c2_84a534a3?usp... : PS3, Line 127: harder Maybe "faster" instead of "harder"?