Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56414 )
Change subject: dediprog.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 4:
(4 comments)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/56414/comment/3ad2c510_23880d44 PS3, Line 221: const int finish,
Please indent at least after the opening parenthesis (or only two-tabs total, I think […]
I used "at least after the opening parenthesis" option. It is useful that you mentioned the rule, I don't remember the rule (maybe I forgot), but now I know!
dediprog_read has it not "at least after", but "at the same place" as the opening parenthesis. Let me know if dediprog_read needs to be changed as well.
https://review.coreboot.org/c/flashrom/+/56414/comment/40daeac5_bd26ba2b PS3, Line 222: struct libusb_context *usb_ctx)
Usually such context information is made the first parameter.
And this way it is also consistent with libusb functions, so even better. There are few functions here with usb_ctx and dediprog_handle, I put those as first parameter.
https://review.coreboot.org/c/flashrom/+/56414/comment/243067f5_213b7ce6 PS3, Line 242: size_t size,
I don't see a need to waste one line each. For instance, cmd & value & idx and […]
Done
https://review.coreboot.org/c/flashrom/+/56414/comment/8546a920_18a3a04a PS3, Line 1025: dp_data->dediprog_devicetype = DEV_UNKNOWN;
This shouldn't be necessary anymore as the data is discarded.
Done