Attention is currently required from: Nico Huber, Angel Pons.

View Change

4 comments:

• File dediprog.c:

  • Patch Set #3, Line 221: const int finish,

    Please indent at least after the opening parenthesis (or only two-tabs total, I think […]

    I used "at least after the opening parenthesis" option. It is useful that you mentioned the rule, I don't remember the rule (maybe I forgot), but now I know!

    dediprog_read has it not "at least after", but "at the same place" as the opening parenthesis. Let me know if dediprog_read needs to be changed as well.

  • Patch Set #3, Line 222: struct libusb_context *usb_ctx)

    Usually such context information is made the first parameter.

    And this way it is also consistent with libusb functions, so even better. There are few functions here with usb_ctx and dediprog_handle, I put those as first parameter.

  • Patch Set #3, Line 242: size_t size,

    I don't see a need to waste one line each. For instance, cmd & value & idx and […]

    Done

  • Patch Set #3, Line 1025: dp_data->dediprog_devicetype = DEV_UNKNOWN;

    This shouldn't be necessary anymore as the data is discarded.

    Done

To view, visit change 56414. To unsubscribe, or for help writing mail filters, visit settings.