Attention is currently required from: Thomas Heijligen, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing ......................................................................
Patch Set 15:
(1 comment)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/42f67230_98f40e3c PS15, Line 43:
Should this be static struct instead?
"No, as this is just a type declaration and thus static doesn't have an effect If it were
struct vl805_spi_data { struct pci_dev *dev; } vl805_data;
then that would define a variable called vl805_data of type struct vl805_spi_data (similar to something like int i = 1; and then the static keyword would make a difference. But vl805_data would be global which we're trying to avoid"