Attention is currently required from: Thomas Heijligen, Nicholas Chin.

View Change

1 comment:

• File vl805.c:

  • Patch Set #15, Line 43:

    Should this be static struct instead?

    "No, as this is just a type declaration and thus static doesn't have an effect
    If it were

    struct vl805_spi_data {
        struct pci_dev *dev;
    } vl805_data;

    
    then that would define a variable called vl805_data of type struct vl805_spi_data (similar to something like int i = 1; and then the static keyword would make a difference. But vl805_data would be global which we're trying to avoid"

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.