Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 1:
(1 comment)
Thanks for taking care of this. Please, whenever fixing warnings that aren't enabled yet, also add a commit on top that enables them :)
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c@192 PS1, Line 192: (enum flashrom_test_state)binfo[i].working; IMHO, it would be better to use `enum flashrom_test_state` everywhere. That we have competing enums seems like a bug that would only be covered up by the cast.