Thanks for taking care of this. Please, whenever fixing warnings
that aren't enabled yet, also add a commit on top that enables
them :)

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #1, Line 192: (enum flashrom_test_state)binfo[i].working;

    IMHO, it would be better to use `enum flashrom_test_state` everywhere. That
    we have competing enums seems like a bug that would only be covered up by
    the cast.

To view, visit change 36946. To unsubscribe, or for help writing mail filters, visit settings.