Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48196 )
Change subject: it85spi.c: Inline it85xx_spi_common_init() ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/flashrom/+/48196/6/it85spi.c File it85spi.c:
https://review.coreboot.org/c/flashrom/+/48196/6/it85spi.c@348 PS6, Line 348: data->shm_io_base = shm_io_base;
Does compiler complain that `shm_io_base` is used while undefined if `!LPC_IO`? […]
Probably reasonable to just assign it to zero at its declaration above Anastasia, `unsigned int shm_io_base = 0;`
https://review.coreboot.org/c/flashrom/+/48196/6/it85spi.c@350 PS6, Line 350: base + 0xD00
The value here depends on exact type of `chipaddr`. Is chipaddr a pointer type or an integer type? […]
+1 to Daniel's comment here, my eye didn't even notice that :O