View Change

2 comments:

• File it85spi.c:

  • Patch Set #6, Line 348: data->shm_io_base = shm_io_base;

    Does compiler complain that `shm_io_base` is used while undefined if `!LPC_IO`? […]

    Probably reasonable to just assign it to zero at its declaration above Anastasia, `unsigned int shm_io_base = 0;`

  • Patch Set #6, Line 350: base + 0xD00

    The value here depends on exact type of `chipaddr`. Is chipaddr a pointer type or an integer type? […]

    +1 to Daniel's comment here, my eye didn't even notice that :O

To view, visit change 48196. To unsubscribe, or for help writing mail filters, visit settings.