Attention is currently required from: Nico Huber, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68221 )
Change subject: writeprotect.c: differentiate lack of WP from lack of implementation
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68221/comment/1d162bf8_be9ab615
PS4, Line 10: preventing confusion
We would still print the former in the NT case, right?
Yes.
I've added the change to handle `NA` value properly because reporting "unimplemented" for `NA` state looks inappropriate. I guess I meant preventing potential confusion as this doesn't improve current situation, just makes better messages possible. However, now that I think about multiple chip models being mapped onto the same entry and that this will only get worse with time, maybe messages shouldn't be precise or they will not be reliable.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187
Gerrit-Change-Number: 68221
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 13 Oct 2022 15:48:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment