Attention is currently required from: Jean THOMAS.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: On first look it seems fine, there are a few minor thinks to do. But I want to have a further look when I'm back from vacation. Thanks for contributing.
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/cab8673e_b8e96e02 PS1, Line 108: static int dirtyjtag_spi_shutdown(void *data) the usb interface should also be released
https://review.coreboot.org/c/flashrom/+/67878/comment/5402a410_7911eb82 PS1, Line 194: int ret = libusb_init(NULL); please use an own libusb_contest and not the default ine (NULL), even if other programmera do so. it can be stored in the djtag_data
https://review.coreboot.org/c/flashrom/+/67878/comment/f5910700_b47025ff PS1, Line 214: ret = libusb_set_auto_detach_kernel_driver(handle, 1); this function is only available on new libusb versions. please use explicit detach and attach in shutdown. have a look at the latest patchen on ch341a_spi