Attention is currently required from: Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 )
Change subject: dummyflasher: move struct declaration & probe_variable_size to spi.(h|c)
......................................................................
Patch Set 2:
(1 comment)
File spi.c:
https://review.coreboot.org/c/flashrom/+/63831/comment/051267b1_bcca1892
PS1, Line 133: int probe_variable_size(struct flashctx *flash)
: {
: unsigned int i;
: const struct emu_data *emu_data = flash->mst->spi.data;
This is not probing anything, right? Just emulating. […]
I've no clue what this function is doing and if it's working as expected. I was only looking for more suitable place. As it's blocking flashrom from getting build without the dummy programmer the current location must be wrong. Maybe we get someone to reexamine the code.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic93c8b9ba7b9f7ce5fe49326c8de34070ca83a2e
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Namyoon Woo
namyoon@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 27 Apr 2022 20:11:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment