Attention is currently required from: Namyoon Woo, Edward O'Callaghan, Anastasia Klimchuk.

View Change

1 comment:

• File spi.c:

  • Patch Set #1, Line 133:

    int probe_variable_size(struct flashctx *flash)
    {
    	unsigned int i;
    	const struct emu_data *emu_data = flash->mst->spi.data;
    

    This is not probing anything, right? Just emulating. […]

    I've no clue what this function is doing and if it's working as expected. I was only looking for more suitable place. As it's blocking flashrom from getting build without the dummy programmer the current location must be wrong. Maybe we get someone to reexamine the code.

To view, visit change 63831. To unsubscribe, or for help writing mail filters, visit settings.