[flashrom-gerrit] Change in ...flashrom[master]: spi: Move 16MiB partitioning up into spi_chip_read()

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33613 )

Change subject: spi: Move 16MiB partitioning up into spi_chip_read()
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+2
>
> It's worth pointing out that this makes the loop look a lot less like the one in spi_write_chunked(). spi_write_chunked() should probably also be simplified with alignment done at a higher-level such that the page and eraseblock alignment are consolidated (since we may need to write additional pages within an eraseblock to restore old contents).
>
> But that's for another patch...

Thanks for the review. Did you have time to test it?