Patch Set 2: Code-Review+2

It's worth pointing out that this makes the loop look a lot less like the one in spi_write_chunked(). spi_write_chunked() should probably also be simplified with alignment done at a higher-level such that the page and eraseblock alignment are consolidated (since we may need to write additional pages within an eraseblock to restore old contents).

But that's for another patch...

Thanks for the review. Did you have time to test it?

View Change

To view, visit change 33613. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iab1fd5b2ea550b4b3ef3e8402e0b6ca218485a51
Gerrit-Change-Number: 33613
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@chromium.org>
Gerrit-Comment-Date: Thu, 20 Jun 2019 07:50:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment