Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64224 )
Change subject: tests: Rearange CPP guards ......................................................................
Patch Set 4:
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/64224/comment/420b0ec0_eff5a29c PS2, Line 87: #if CONFIG_DUMMY == 1
Splitting the file is a good idea. I would be careful with the use of weak symbols. […]
That's ok, I wasn't thinking of this change of course sorry if it sounded like that.
Agree re weak symbols, definitely be extremely conservative with them as the same with the pre-processor but probably in this very specific case they _may_ indeed make sense. programmer_table is a interesting lens to look at the problem, ultimately it is subjective but best to have all the branching in one corner that across the whole file is the fundamental idea I had in mind.
I created a issue to move the discussion over there https://ticket.coreboot.org/issues/380 and to track the idea and whatever comes of it. Cheers Thomas!