View Change

1 comment:

• File tests/lifecycle.c:

  • Patch Set #2, Line 87: #if CONFIG_DUMMY == 1

    Splitting the file is a good idea. I would be careful with the use of weak symbols. […]

    That's ok, I wasn't thinking of this change of course sorry if it sounded like that.

    Agree re weak symbols, definitely be extremely conservative with them as the same with the pre-processor but probably in this very specific case they _may_ indeed make sense. programmer_table is a interesting lens to look at the problem, ultimately it is subjective but best to have all the branching in one corner that across the whole file is the fundamental idea I had in mind.

    I created a issue to move the discussion over there https://ticket.coreboot.org/issues/380 and to track the idea and whatever comes of it. Cheers Thomas!

To view, visit change 64224. To unsubscribe, or for help writing mail filters, visit settings.