Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34621 )
Change subject: Provide strndup implementation if compiled with MinGW because it is a POSIX only method ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
https://review.coreboot.org/c/flashrom/+/34621/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34621/4//COMMIT_MSG@6 PS4, Line 6: Add a summary line, e.g. `helpers: Implement strndup() for MinGW`
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c File helpers.c:
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@109 PS4, Line 109: if(strlen(src) > maxlen) { Add a space after `if`, please.
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@111 PS4, Line 111: if((retbuf = malloc( 1 + maxlen )) != NULL) { Also here. And no spaces inside the parenteses (i.e. `malloc(1 + maxlen)`).
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@112 PS4, Line 112: memcpy( retbuf, src, maxlen ); spaces...