Patch set 4:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #4, Line 6:

    Add a summary line, e.g. `helpers: Implement strndup() for MinGW`

• File helpers.c:

  • Patch Set #4, Line 109: if(strlen(src) > maxlen) {

    Add a space after `if`, please.

  • Patch Set #4, Line 111: if((retbuf = malloc( 1 + maxlen )) != NULL) {

    Also here. And no spaces inside the parenteses (i.e. `malloc(1 + maxlen)`).

  • Patch Set #4, Line 112: memcpy( retbuf, src, maxlen );

    spaces...

To view, visit change 34621. To unsubscribe, or for help writing mail filters, visit settings.