12 Nov
2019
12 Nov
'19
3:27 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36717 )
Change subject: flashchips: Add W25Q128JW_DTR ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/36717/3/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/36717/3/flashchips.c@16424 PS3, Line 16424: TEST_OK_PREW
Did you test all the operations here?
In the ChromeOS flashrom tree under utils there is a program called flashrom_tester you can use to verify all the operations work. It comes by default as part of the test image.
--
To view, visit https://review.coreboot.org/c/flashrom/+/36717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifc28878b17dc10da2cfd8f82fffbd57adb22799e
Gerrit-Change-Number: 36717
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Nov 2019 03:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment