Attention is currently required from: Thomas Heijligen, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59281 )
Change subject: pcidev.c: Simplify by consolidating common logic ......................................................................
Patch Set 5: Code-Review-2
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59281/comment/ef671502_aef958a5 PS5, Line 9: As observed by Angel Pos, It looks like `pci_filter_init()`
typo: Pons
Done
https://review.coreboot.org/c/flashrom/+/59281/comment/d3999a13_55672560 PS5, Line 10: initialises the device ID to -1
What is resulting action from this fact?
Fixed?
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/59281/comment/757385af_1acfb435 PS5, Line 166: struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass)
The new implementation tests only the first pci device from a vendor on it's class. […]
That's true, thanks for spotting it. I think I botched up the rebase locally i'll try to get some time to look at this again and will resolve once fixed.
https://review.coreboot.org/c/flashrom/+/59281/comment/15c5c572_97216c42 PS5, Line 168: struct pci_dev *temp = pcidev_find(vendor, -1);
Please comment here why to use -1 and it's special meaning. […]
Done