Attention is currently required from: Thomas Heijligen, Angel Pons.

Patch set 5:Code-Review -2

View Change

4 comments:

• Commit Message:

  • Patch Set #5, Line 9: As observed by Angel Pos, It looks like `pci_filter_init()`

    typo: Pons

    Done

  • Patch Set #5, Line 10: initialises the device ID to -1

    What is resulting action from this fact?

    Fixed?

• File pcidev.c:

  • Patch Set #5, Line 166: struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass)

    The new implementation tests only the first pci device from a vendor on it's class. […]

    That's true, thanks for spotting it. I think I botched up the rebase locally i'll try to get some time to look at this again and will resolve once fixed.

  • Patch Set #5, Line 168: struct pci_dev *temp = pcidev_find(vendor, -1);

    Please comment here why to use -1 and it's special meaning. […]

    Done

To view, visit change 59281. To unsubscribe, or for help writing mail filters, visit settings.