David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43140 )
Change subject: Makefile: Fix building on AArch64 NixOS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/43140/1/Makefile
File Makefile:
https://review.coreboot.org/c/flashrom/+/43140/1/Makefile@110
PS1, Line 110: grep '"'
As mentioned on the GitHub issue, I'd prefer to improve the parsing step. […]
`gcc -E` on archtest.c, endianness.c, and os.h should all produce the result on the last line, so perhaps we can skip complicated grep'ing and just use `tail` and `cut` to extract the information we need?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/43140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4477a71e758cf9ecad2c22f3b77bc6508a3510
Gerrit-Change-Number: 43140
Gerrit-PatchSet: 1
Gerrit-Owner: Pyry Kontio
pyry.kontio@drasa.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jul 2020 21:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment