Patch set 1:Code-Review +1

View Change

1 comment:

• File Makefile:

  • Patch Set #1, Line 110: grep '"'

    As mentioned on the GitHub issue, I'd prefer to improve the parsing step. […]

    `gcc -E` on archtest.c, endianness.c, and os.h should all produce the result on the last line, so perhaps we can skip complicated grep'ing and just use `tail` and `cut` to extract the information we need?

To view, visit change 43140. To unsubscribe, or for help writing mail filters, visit settings.