Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39686 )
Change subject: i2c_helper: Add support for the Linux I2C subsystem ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/flashrom/+/39686/3/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/39686/3/Makefile@1056 PS3, Line 1056: FEATURE_CFLAGS += -D'CONFIG_LINUX_I2C_HELPER=1'
I think the 'feature flag' here is just `CONFIG_I2C_SUPPORT` here.
Done
https://review.coreboot.org/c/flashrom/+/39686/3/i2c_helper_linux.c File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/39686/3/i2c_helper_linux.c@114 PS3, Line 114:
trim these trailing '\n' at the end of the files.
There seems no '\n' here.
https://review.coreboot.org/c/flashrom/+/39686/3/meson.build File meson.build:
https://review.coreboot.org/c/flashrom/+/39686/3/meson.build@294 PS3, Line 294: config_linux_i2c_helper
This doesn't need a user specified config, rather it should just be part of the core modules and onl […]
Done
https://review.coreboot.org/c/flashrom/+/39686/3/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/39686/3/meson_options.txt@37 PS3, Line 37: : option('config_linux_i2c_helper', type: 'boolean', value : true, description : 'Linux I2C control')
not required.
Done