View Change

4 comments:

• File Makefile:

  • Patch Set #3, Line 1056: FEATURE_CFLAGS += -D'CONFIG_LINUX_I2C_HELPER=1'

    I think the 'feature flag' here is just `CONFIG_I2C_SUPPORT` here.

    Done

• File i2c_helper_linux.c:

  • Patch Set #3, Line 114:

    trim these trailing '\n' at the end of the files.

    There seems no '\n' here.

• File meson.build:

  • Patch Set #3, Line 294: config_linux_i2c_helper

    This doesn't need a user specified config, rather it should just be part of the core modules and onl […]

    Done

• File meson_options.txt:

  • Patch Set #3, Line 37:

    
    option('config_linux_i2c_helper', type: 'boolean', value : true, description : 'Linux I2C control')
    

    not required.

    Done

To view, visit change 39686. To unsubscribe, or for help writing mail filters, visit settings.