Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 )
Change subject: raiden_debug_spi.c: Add protocol based configuration to init ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG@10 PS3, Line 10: The changes include:
These are essentially each their own commit to make this properly reviewable.
Done
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG@12 PS3, Line 12: Setting of USB SPI limits based on the device's USB protocol
commit 1.
Done
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG@14 PS3, Line 14: * Creation of context states to keep track of bytes written to : and read from the device and individual USB packets.
commit 3?
Done
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG@17 PS3, Line 17: * Creation of helper functions for handling transfer of data : between the USB packets and the data buffers.
commit 2?
Done
https://review.coreboot.org/c/flashrom/+/41532/3//COMMIT_MSG@20 PS3, Line 20: * Removal of magic numbers on the USB return codes. Some renaming : of to make the protocol version clear.
commit 0.
Done