View Change
5 comments:
Commit Message:
Patch Set #3, Line 10: The changes include:
These are essentially each their own commit to make this properly reviewable.
Done
Patch Set #3, Line 12: Setting of USB SPI limits based on the device's USB protocol
commit 1.
Done
Patch Set #3, Line 14:
* Creation of context states to keep track of bytes written to
and read from the device and individual USB packets.
commit 3?
Done
Patch Set #3, Line 17:
* Creation of helper functions for handling transfer of data
between the USB packets and the data buffers.
commit 2?
Done
Patch Set #3, Line 20:
* Removal of magic numbers on the USB return codes. Some renaming
of to make the protocol version clear.
commit 0.
Done
To view, visit change 41532. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id404af14e55fa0884e29f28880206aaad4deba66
Gerrit-Change-Number: 41532
Gerrit-PatchSet: 16
Gerrit-Owner: Brian Nemec <bnemec@google.com>
Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 20 Jul 2020 04:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment