Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 26: (2 comments) https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c@249 PS26, Line 249: i >= 0
Did you test this with unexpected inputs, e.g. command line argument of 1.0V? […] Done
https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c@440 PS26, Line 440: strlen(ignore_io_voltage_limits_str) == 3 : && strstr("yes", ignore_io_voltage_limits_str) == 0
This should be the same as […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 26 Gerrit-Owner: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev@gmail.com> Gerrit-CC: Stefan T <stefan.tauner@gmx.at> Gerrit-Comment-Date: Tue, 22 Oct 2019 20:36:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment