Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33343 )
Change subject: atavia.c: Remove unneeded 'else' ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patch Set 1:
(1 comment)
Can we discuss this first? How is not having the `else` better? The `continue` on the else path also wasn't necessary, but I assume the author put it there to balance the branches, for better legibility.
I've just checked that the resulting code is the same, functionally speaking. But yes, this one is ugly.
https://review.coreboot.org/#/c/33343/1/atavia.c File atavia.c:
https://review.coreboot.org/#/c/33343/1/atavia.c@107 PS1, Line 107: continue;
This is... well, looks just wrong.
Indeed.