Patch Set 1:

(1 comment)

Can we discuss this first? How is not having the `else`
better? The `continue` on the else path also wasn't
necessary, but I assume the author put it there to
balance the branches, for better legibility.

I've just checked that the resulting code is the same, functionally speaking. But yes, this one is ugly.

Patch set 1:Code-Review +1

View Change

1 comment:

• File atavia.c:

  • Patch Set #1, Line 107: continue;

    This is... well, looks just wrong.

    Indeed.

To view, visit change 33343. To unsubscribe, or for help writing mail filters, visit settings.