Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34413 )
Change subject: flashchips: Add support for N25Q512..1E ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Looks good, but it would be nice to add all erase opcodes.
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c@10608 PS2, Line 10608: }, { Datasheet also mentions 32KiB 0x5c and 0x52.
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c@10616 PS2, Line 10616: .block_erase = spi_block_erase_c7, Also 0x60 according to the datasheet. The reason that we usually add all opcodes is that there are programmers that may restrict what we can send to the flash.