Looks good, but it would be nice to add all erase opcodes.

Patch set 2:Code-Review +2

View Change

2 comments:

• File flashchips.c:

  • Patch Set #2, Line 10608: }, {

    Datasheet also mentions 32KiB 0x5c and 0x52.

  • Patch Set #2, Line 10616: .block_erase = spi_block_erase_c7,

    Also 0x60 according to the datasheet. The reason that we usually add all
    opcodes is that there are programmers that may restrict what we can send
    to the flash.

To view, visit change 34413. To unsubscribe, or for help writing mail filters, visit settings.