Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.
Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67474
to look at the new patch set (#3).
Change subject: flashrom.c: Drop emergency_help_message() static local ......................................................................
flashrom.c: Drop emergency_help_message() static local
The emergency help message is only relevent under one specific sitution: i ) The internal programmer was used, && ii) The user was intending not to do a destructive operation.
Since erasing the chip is inherantly a destructive operation that was requested warning the user they have a unknown state of spi flash isn't partially (as noted in the FIXME). Therefore just drop the call and allow `emergency_help_message()` to be static local.
Change-Id: Ib0d390c44e7a851e684014925a25c8b259b810cd Signed-off-by: Edward O'Callaghan quasisec@google.com --- M cli_classic.c M flashrom.c M include/flash.h 3 files changed, 22 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/67474/3