Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.

Edward O'Callaghan uploaded patch set #3 to this change.

View Change

flashrom.c: Drop emergency_help_message() static local

The emergency help message is only relevent under one
specific sitution:
i ) The internal programmer was used, &&
ii) The user was intending not to do a destructive operation.

Since erasing the chip is inherantly a destructive operation
that was requested warning the user they have a unknown state
of spi flash isn't partially (as noted in the FIXME). Therefore
just drop the call and allow `emergency_help_message()` to be
static local.

Change-Id: Ib0d390c44e7a851e684014925a25c8b259b810cd
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M cli_classic.c
M flashrom.c
M include/flash.h
3 files changed, 22 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/67474/3

To view, visit change 67474. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib0d390c44e7a851e684014925a25c8b259b810cd
Gerrit-Change-Number: 67474
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: newpatchset