Attention is currently required from: Subrata Banik, Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62867 )
Change subject: ichspi: Unify timeouts across all SPI operations to 30s ......................................................................
Patch Set 13:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62867/comment/a8e3d2a0_8d05aa73 PS12, Line 38: Here is the timeout calculation for any hardware sequencing operation: : Worst Case Operational Delay = : (Maximum Time consumed by a SPI operation + Any marginal : adjustment) : : Timeout Recommendation for Hardware Sequencing Operation = : ((Worst Case Operational Delay) * (#No. Of SPI Master - 1) + : Current Operational latency) : : Assume, on Intel platform with 2 SPI master like, Host CPU and CSE, the : Timeout Calculation for SPI Write Operation would look like as below: : : Maximum Time consumed by a SPI Operation = 2 seconds : (for SPI Erase Operation as per Winbond Data Sheet) : : Worst Case Operational Delay = (2 seconds + 50 milliseconds) = : 2 seconds 50 milliseconds : Timeout Recommendation for Hardware Seq Operation = : (2 seconds 50 milliseconds) * (2 - 1) + 15 milliseconds : (for SPI Write Operation as per Winbond Data Sheet) : = 2 seconds 65 milliseconds
Doing the calculation with these numbers can be a bit confusing. I'd do it with the estimated worst-case numbers right away (i.e. 6 masters, 5s).
Shorting some things might make it more readable, e.g. `2.05s` instead of `2 seconds 50 milliseconds`, also shorter identifiers and removing unnecessary parentheses can help legibility.
ACK
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62867/comment/b5e01201_699130ba PS12, Line 1281: operation
`operations`? because multiple masters would preform multiple operations?
ACK
https://review.coreboot.org/c/flashrom/+/62867/comment/69952a8d_c524dd26 PS12, Line 1282: introduces
`introduce` without s, I guess
ACK