Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55720 )
Change subject: nicintel_spi.c: Cache FLA register value ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/55720/comment/73d23472_c0fe7d16 PS2, Line 122: pci_mmio_readl If somebody else is still in charge, could the register value still change? or is the register contents only ever set by the host?
If it can still change, we should keep the last value read.
https://review.coreboot.org/c/flashrom/+/55720/comment/8c579d58_211cc327 PS2, Line 129: data->fla = pci_mmio_readl(data->spibar + FLA); NB. If we were indeed in charge of the interface, this read shouldn't be necessary.