Attention is currently required from: Angel Pons.

Patch set 2:Code-Review +1

View Change

2 comments:

• File nicintel_spi.c:

  • Patch Set #2, Line 122: pci_mmio_readl

    If somebody else is still in charge, could the register value still
    change? or is the register contents only ever set by the host?

    If it can still change, we should keep the last value read.

  • Patch Set #2, Line 129: data->fla = pci_mmio_readl(data->spibar + FLA);

    NB. If we were indeed in charge of the interface, this read shouldn't be necessary.

To view, visit change 55720. To unsubscribe, or for help writing mail filters, visit settings.