Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44879 ) Change subject: support variable-size SPI chip for dummy programmer ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Broke building with CONFIG_DUMMY=no; probe_variable_size() would have to move to a chip driver. It needs access to programmer internals, though. That's what the opaque master is there for... Seems all borked. It also casts objects of all programmers to the dummy one. Only bails out by chance. Another 3 hours wasted on a Saturday night, please somebody remove this code. We've been patching this for almost a year now and it's still broken. -- To view, visit https://review.coreboot.org/c/flashrom/+/44879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff266e151459561b126ecfd1c47420b385be1db2 Gerrit-Change-Number: 44879 Gerrit-PatchSet: 8 Gerrit-Owner: Namyoon Woo <namyoon@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Namyoon Woo <namyoon@google.com> Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Sat, 26 Jun 2021 22:55:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment