11 Oct
2022
11 Oct
'22
7:17 a.m.
Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Mario Kicherer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 )
Change subject: flashchips.c: add support for ISSI IS25LP016 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: Other than the whitespace, looks reasonable. Haven't checked against the datasheet, though.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68295/comment/3822480d_36c2765b PS1, Line 7381: We use tabs to align the equals signs
--
To view, visit https://review.coreboot.org/c/flashrom/+/68295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183
Gerrit-Change-Number: 68295
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Kicherer
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Mario Kicherer
Gerrit-Comment-Date: Tue, 11 Oct 2022 10:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment