Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40325 ) Change subject: Add writeprotect support ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/flashrom/+/40325/2/writeprotect.c File writeprotect.c: https://review.coreboot.org/c/flashrom/+/40325/2/writeprotect.c@140 PS2, Line 140: struct wp_range_descriptor en25f40_ranges[] = {
they are only used in this implementation, I think you want the reverse here and them to be static. Well, that would be nice as well. My idea is to have tables in a separate file, so that the code doesn't get lost among the many tables
-- To view, visit https://review.coreboot.org/c/flashrom/+/40325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id93b5a1cb2da476fa8a7dde41d7b963024117474 Gerrit-Change-Number: 40325 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Sun, 12 Apr 2020 20:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment