Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges() ......................................................................
Patch Set 46:
(4 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58481/comment/46e1279d_016069ed PS44, Line 189: /* For equal length ranges, list the one with a lower start address */ : /* first. */
This looks like a multiline comment pretending to be two single-line comments in a row :) Probably s […]
Done
https://review.coreboot.org/c/flashrom/+/58481/comment/515e3765_c67556e8 PS44, Line 194: /* Ranges a and b are identical, order them by the values of the bits */ : /* that are used to select them. */
And this one too
Done
https://review.coreboot.org/c/flashrom/+/58481/comment/0059bae6_32a439e2 PS44, Line 267: /* Enumerate all values the range bits can take and find the range */ : /* associated with each one. */
And this one too
Done
https://review.coreboot.org/c/flashrom/+/58481/comment/623f8b0b_9247b5dc PS44, Line 270: /* Extract bits from the range index and assign them to members */ : /* of the wp_bits structure. */
And this one
Done