Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.
View Change
4 comments:
File writeprotect.c:
Patch Set #44, Line 189:
/* For equal length ranges, list the one with a lower start address */
/* first. */
This looks like a multiline comment pretending to be two single-line comments in a row :) Probably s […]
Done
Patch Set #44, Line 194:
/* Ranges a and b are identical, order them by the values of the bits */
/* that are used to select them. */
And this one too
Done
Patch Set #44, Line 267:
/* Enumerate all values the range bits can take and find the range */
/* associated with each one. */
And this one too
Done
Patch Set #44, Line 270:
/* Extract bits from the range index and assign them to members */
/* of the wp_bits structure. */
And this one
Done
To view, visit change 58481. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d
Gerrit-Change-Number: 58481
Gerrit-PatchSet: 46
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 12:07:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment