Attention is currently required from: Thomas Heijligen, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB 3 XHCI flashing ......................................................................
Patch Set 14:
(10 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/0364b529_77a15288 PS12, Line 69: struct pci_dev *dev
This is still wrong. it must be […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/f75c77c9_38440eef PS12, Line 76: dev
And here […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/b77e6c8c_f89af3ca PS12, Line 85: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/2c4ad1b1_d2c32e95 PS12, Line 86: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/a1784228_fc3ad1a6 PS12, Line 90: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/cd5c77de_68bc4b77 PS12, Line 94: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/ed47d9c6_4407cde4 PS12, Line 95: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/88aba5a2_18ea7087 PS12, Line 102: dev
`data->dev`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/e1150590_f62593e1 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));
Please tests if the allocation was successful. […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/3381dfcd_681ced49 PS12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));
Please move the allocation of vl805_spi_data below […]
Done