Attention is currently required from: Thomas Heijligen, Nicholas Chin.
View Change
10 comments:
File vl805.c:
Patch Set #12, Line 69: struct pci_dev *dev
This is still wrong. it must be […]
Done
Patch Set #12, Line 76: dev
And here […]
Done
Patch Set #12, Line 85: dev
`data->dev`
Done
Patch Set #12, Line 86: dev
`data->dev`
Done
Patch Set #12, Line 90: dev
`data->dev`
Done
Patch Set #12, Line 94: dev
`data->dev`
Done
Patch Set #12, Line 95: dev
`data->dev`
Done
Patch Set #12, Line 102: dev
`data->dev`
Done
Patch Set #12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));
Please tests if the allocation was successful. […]
Done
Patch Set #12, Line 140: struct vl805_spi_data *data = calloc(1, sizeof(*data));
Please move the allocation of vl805_spi_data below […]
Done
To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 14
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha@gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 18:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment