Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37777 )
Change subject: chipset_enable.c: Enable Tiger Lake U support ......................................................................
Patch Set 2:
(1 comment)
Same as for https://review.coreboot.org/c/flashrom/+/37677, I don't have documentation for this SoC available. So no way to review this. Note that all the occurrences of CHIPSET_300_SERIES_CANNON_POINT in the code would need to be reviewed or tested.
Alternatively to waiting for Intel docs, we could also ask them to add all the details to Documentation/ first. So we'd have something to compare to during review of the code.
https://review.coreboot.org/c/flashrom/+/37777/2/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/37777/2/chipset_enable.c@1999 PS2, Line 1999: F FWH support is not implemented, AFAIR.