Same as for, I don't
have documentation for this SoC available. So no way to review this.
Note that all the occurrences of CHIPSET_300_SERIES_CANNON_POINT
in the code would need to be reviewed or tested.

Alternatively to waiting for Intel docs, we could also ask them to
add all the details to Documentation/ first. So we'd have something
to compare to during review of the code.

View Change

1 comment:

To view, visit change 37777. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c13e0173c9b5e17d2ae197f4a4ab9aa2825c1b3
Gerrit-Change-Number: 37777
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Edward O'Callaghan <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Furquan Shaikh <>
Gerrit-CC: Nico Huber <>
Gerrit-Comment-Date: Fri, 17 Jan 2020 12:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment